Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Rev dependencies to k8s 1.13 #279

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Jan 4, 2019

Updates Kubernetes dependencies to v1.13, required for #275

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 4, 2019
@detiber
Copy link
Member Author

detiber commented Jan 4, 2019

@vincepri heads up

@detiber
Copy link
Member Author

detiber commented Jan 4, 2019

/assign @DirectXMan12

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Jan 7, 2019

To check that this doesn't change the signature of our public interface,use #229. I need to fix it up to get it mergable, but you can run it using the code in the PR in the mean time. Just generate "before" and "after" outputs, and diff them to make sure things haven't changed.

@detiber
Copy link
Member Author

detiber commented Jan 8, 2019

@DirectXMan12 running the external objects tooling returns the following diff:

diff ~/tmp/cr-external-objects.before ~/tmp/cr-external-objects.after
< "k8s.io/client-go/rest".Config -- struct{Host string; APIPath string; k8s.io/client-go/rest.ContentConfig; Username string; Password string; BearerToken string; Impersonate k8s.io/client-go/rest.ImpersonationConfig; AuthProvider *k8s.io/client-go/tools/clientcmd/api.AuthProviderConfig; AuthConfigPersister k8s.io/client-go/rest.AuthProviderConfigPersister; ExecProvider *k8s.io/client-go/tools/clientcmd/api.ExecConfig; k8s.io/client-go/rest.TLSClientConfig; UserAgent string; Transport net/http.RoundTripper; WrapTransport func(rt net/http.RoundTripper) net/http.RoundTripper; QPS float32; Burst int; RateLimiter k8s.io/client-go/util/flowcontrol.RateLimiter; Timeout time.Duration; Dial func(ctx context.Context, network string, address string) (net.Conn, error)}
---
> "k8s.io/client-go/rest".Config -- struct{Host string; APIPath string; k8s.io/client-go/rest.ContentConfig; Username string; Password string; BearerToken string; BearerTokenFile string; Impersonate k8s.io/client-go/rest.ImpersonationConfig; AuthProvider *k8s.io/client-go/tools/clientcmd/api.AuthProviderConfig; AuthConfigPersister k8s.io/client-go/rest.AuthProviderConfigPersister; ExecProvider *k8s.io/client-go/tools/clientcmd/api.ExecConfig; k8s.io/client-go/rest.TLSClientConfig; UserAgent string; Transport net/http.RoundTripper; WrapTransport func(rt net/http.RoundTripper) net/http.RoundTripper; QPS float32; Burst int; RateLimiter k8s.io/client-go/util/flowcontrol.RateLimiter; Timeout time.Duration; Dial func(ctxcontext.Context, network string, address string) (net.Conn, error)}

There is a single (additive) change to the client-go/rest.Config object that adds BearerTokenFile string to the object.

@mengqiy
Copy link
Member

mengqiy commented Jan 9, 2019

The diff above seems to be fine.

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

Thanks for your work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6d99d78 into kubernetes-sigs:master Jan 9, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
remove cert generator and add redirection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants