Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ MOD: Add a new config in manager.New to set on stopped leading function #2862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calmkart
Copy link

manager.New() method can't set onStoppedLeading function to options, so we can't set some special LeaderCallbacks in controller-runtime New Method to create a manager.

just add a option onStoppedLeading in manager.Options and set it to manager.controllerManager.onStoppedLeading

@k8s-ci-robot k8s-ci-robot requested a review from inteon June 25, 2024 10:14
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: calmkart
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @calmkart. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2024
@troy0820
Copy link
Member

/retitle ✨ MOD: Add a new config in manager.New to set on stopped leading function

@k8s-ci-robot k8s-ci-robot changed the title ✨ MOD:add a new config in manager.Mew to set on stopped leading function ✨ MOD: Add a new config in manager.New to set on stopped leading function Jun 25, 2024
@@ -201,6 +202,10 @@ type Options struct {
// LeaseDuration time first.
LeaderElectionReleaseOnCancel bool

// OnStoppedLeading is callled when the leader election lease is lost.
// It can be overridden for tests.
OnStoppedLeading func()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just run this after the manager ended to achieve the same result or not?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost leader is not equal manager ended. so we can't do that in operator's preStop or other hook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference? The manager ends after it lost the leader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants