Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Only use json-patch v4 #2864

Closed
wants to merge 1 commit into from
Closed

✨ Only use json-patch v4 #2864

wants to merge 1 commit into from

Conversation

skitt
Copy link
Member

@skitt skitt commented Jun 27, 2024

controller-runtime currently depends on both v4 and v5 of evanphx/json-patch. For various reasons k/k is staying on v4, so it makes sense for controller-runtime to follow suit. This drops the v5 dependency in favour of v4 only.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skitt
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@skitt
Only use json-patch v4
09def1d 
controller-runtime currently depends on both v4 and v5 of
evanphx/json-patch. For various reasons k/k is staying on v4, so it
makes sense for controller-runtime to follow suit. This drops the v5
dependency in favour of v4 only.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt force-pushed the drop-json-patch-v5-dependency branch from 324fe6e to 09def1d Compare June 27, 2024 19:58
@k8s-ci-robot
Copy link
Contributor

@skitt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-test 09def1d link true /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skitt skitt marked this pull request as draft June 27, 2024 20:16
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
@alvaroaleman
Copy link
Member

I think this change would re-introduce #2603

@skitt
Copy link
Member Author

skitt commented Jul 1, 2024

I think this change would re-introduce #2603

It would indeed, and your test and the explanations in the commit introducing it make it clear enough.

@skitt skitt closed this Jul 1, 2024
@skitt skitt deleted the drop-json-patch-v5-dependency branch July 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skitt @k8s-ci-robot @alvaroaleman