Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Convert client.List to use functional options #294

Merged
merged 1 commit into from
Jan 16, 2019

Commits on Jan 16, 2019

  1. ⚠️ Convert client.List to use functional options

    Replaces:
    
    List(ctx, ListOptions, list)
    
    with:
    
    List(ctx, list, ...option)
    
    This matches the upcoming functional options signature of client.Delete.
    
    To use the previous builder options, use the UseListOptions functional
    option:
    
    lo := &client.ListOptions{}
    client.List(ctx, list, client.UseListOptions(
      lo.InNamespace(ns).MatchingLabels(labels)
      ))
    
    Ported kubernetes-sigs#106 PR
    droot committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    3285ad1 View commit details
    Browse the repository at this point in the history