🐛 update call to ZapLoggerTo after refactor #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/cc @mengqiy |
mengqiy
reviewed
Jan 24, 2019
pkg/webhook/webhook_suite_test.go
Outdated
| @@ -38,7 +38,7 @@ var cfg *rest.Config | |||
| var clientset *kubernetes.Clientset | |||
|
|
|||
| var _ = BeforeSuite(func(done Done) { | |||
| logf.SetLogger(logf.ZapLoggerTo(GinkgoWriter, true)) | |||
| logf.SetLogger(logf.ZapLoggerTo(true)) | |||
There was a problem hiding this comment.
Should it be changed to logf.SetLogger(zap.LoggerTo(GinkgoWriter, true)) to be consistent with others? e.g.
Did I miss something?
There was a problem hiding this comment.
My apologies didn't see this. and didn't see another option on logf so I got confused.
shawn-hurley
force-pushed
the
bug/fix-build
branch
from
2bfd480
to
889f260
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mengqiy
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: shawn-hurley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tests so that the build can pass.