⚠️ webhook redesign for generic case #323

This makes sure to run go vet on the examples and the alias file, and turns goimports back on.

We had goimports turned off. When turned back on, it complained about a bunch of stuff. This fixes that.

The example was still using the old list options arguments style (second argument instead of last argument), which made it fail to compile. This also makes sure we run go test on the whole project, instead of just pkg/...

The webhook server logic was not handling injection correctly -- it implemented injection for a couple of specific fields, rather than receiving and dealing with an injectfunc. This fixes that. As a side effect, it also removes the handle to manager and client from the webhook server, since those aren't used by the server, and should thus be injected from the manager.

This flattens down the webhook package structure, removing dedicated `types` packages in favor of having things in the relevant places. To do this, the inject interface definitions for admission were also moved to the admission controller location, but they actually make some amount of sense living there. It also renames and restructures a couple of the types for code clarity (e.g. WebhookTypeMutating to MutatingWebhook) or to follow the convention of other types in CR (e.g. Making wrapped types from core Kubernetes nested fields).

We don't have anywhere that we actually make use of decoder as an interface, so switch to just have a concrete implementation.

This extracts out the multi-handler support into separate interfaces. That simplifies the code, makes it easier to test directly, and allows us to drop the now-extraneous Type field. This simultaneously removes the builder (for now) since it doesn't actually make anything simpler. Along the way, we also refactor some common functionality out into a helper on reponse itself as opposed to being run by different bits of the webhook.

This cleans up tests to more closely follow CR style, favoring behavior-style tests as opposed to pure unit tests.

This renames a few ambigously named fields in the webhook server, removes some extraneous fields and methods, and removes the unnecessary constructor for Server.

It was only being used for registering metrics, and that can be done with the path instead.

This removes the path functionality from admission webhooks, since it's not strictly needed. Relevant metrics are moved up to the webhook server, and path is added to register. This also introduces a couple of helpers that should make code a bit clearer when writing admission webhooks (Allowed, Denied, Patched), and an alias file to avoid importing both webhook and webhook/admission.

This ensures that decoders (which are no longer constructed in the manager) are properly injected into webhook handlers. The webhook itself receives a scheme, which it uses to construct a decoder.

Due to a weird interaction between the unstructured decoder (which demands APIVersion and Kind fields) and the API server (which fails to set those fields on the embedded object in admission requests), we can't use the normal decoders, nor can we call json.Unmarshal directly on the unstructured (since it implements an unmarshaller that calls back into the decoder). This detects unstructured objects, and does the right thing for them.

This moves the examples to an actual Go example file, so that we can be sure that they actually compile.

It's not used anywhere any more.

It's the same name used in alias.go, and it produces less-verbose code without loss of readability.

The were incorrect (would not have compiled), are mostly duplicates of examples/*webhook.go, and can't be easily checked for being up-to-date.

This gives each webhook a log, so that serving errors can be tied to a particuluar webhook.

Nothing was missing from the tree (due to transitive deps), just missing from being required by Gopkg.lock.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ webhook redesign for generic case #323

⚠️ webhook redesign for generic case #323

Commits on Feb 21, 2019