🐛 try manager's config before kubeconfig #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
mengqiy
force-pushed
the
builderconfig
branch
from
28629e9
to
001fcab
Compare
mengqiy
changed the title
|
This PR is needed to get kubernetes-sigs/kubebuilder#603 passing the tests. |
mengqiy
force-pushed
the
builderconfig
branch
from
001fcab
to
2d0ff5e
Compare
mengqiy
pushed a commit
to mengqiy/kubebuilder
that referenced
this pull request
Feb 15, 2019
|
/lgtm looks like this was left-over from when the builder was mostly for single-controller managers |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use builder pkg to construct a controller, if a config is provided, we should use it.
If a config is not provided by the user, we should try to use manager's config.
If manager is not specified, we should then try to use GetConfig().