⚠️ Add Server-Side DryRun support to Client

[JoelSpeed]

This PR adds CreateOptions and UpdateOptions to the Client package to allow client users to set the DryRun option when creating and updating resources using the client. This should allow users to see the result of all Admission controllers before persisting changes.

I've attempted to match the patterns in DeleteOptions and ListOptions as much as possible but since the only valid value for DryRun is all (see here) I've not made that configurable, but it could be easily changed. I've also had to name the two OptionFuncs CreateDryRunAll and UpdateDryRunAll which I don't particularly like, has anyway any better ideas for names for these?

[JoelSpeed]

/assign @droot

[DirectXMan12]

you missed fakeClient, otherwise LGTM 👍

[JoelSpeed]

@DirectXMan12 I've updated the fake client to basically do a no-op when passed the DryRunAll options, do you think that is sufficient?

[DirectXMan12]

yeah, I think that's sufficient. Looks like travis is complaining about 2 tests.

[JoelSpeed]

Looks like travis is complaining about 2 tests.

I think this is because the K8s version being used in the tests is 1.10.1 which I guess silently ignores the DryRun option, am I ok to update this to a newer version?

controller-runtime/hack/check-everything.sh

Line 22 in 6649bdb

k8s_version=1.10.1

controller-runtime/hack/check-everything.sh

Lines 55 to 57 in 6649bdb

	header_text "fetching tools"
	kb_tools_archive_name="kubebuilder-tools-$k8s_version-$goos-$goarch.tar.gz"
	kb_tools_download_url="https://storage.googleapis.com/kubebuilder-tools/$kb_tools_archive_name"

[DirectXMan12]

Yeah, go ahead and update to a newer version :-)

[DirectXMan12]

1.13.1 is the latest, IIRC. I've turned on listing on that bucket, so you should be able to check yourself now.

[JoelSpeed]

@DirectXMan12 I've bumped the K8s version and the tests are passing now

[DirectXMan12]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DirectXMan12]

/hold

[DirectXMan12]

technically this is breaking, since it changes an interface -- needed to update title

/hold cancel