Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix typos in comment #339

Merged
merged 1 commit into from
Feb 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Controller interface {
//
// Watch may be provided one or more Predicates to filter events before
// they are given to the EventHandler. Events will be passed to the
// EventHandler iff all provided Predicates evaluate to true.
// EventHandler if all provided Predicates evaluate to true.
Watch(src source.Source, eventhandler handler.EventHandler, predicates ...predicate.Predicate) error

// Start starts the controller. Start blocks until stop is closed or a
Expand Down
6 changes: 3 additions & 3 deletions pkg/source/internal/eventsource.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type EventHandler struct {
Predicates []predicate.Predicate
}

// OnAdd creates and CreateEvent and calls Create on EventHandler
// OnAdd creates CreateEvent and calls Create on EventHandler
func (e EventHandler) OnAdd(obj interface{}) {
c := event.CreateEvent{}

Expand Down Expand Up @@ -74,7 +74,7 @@ func (e EventHandler) OnAdd(obj interface{}) {
e.EventHandler.Create(c, e.Queue)
}

// OnUpdate creates and UpdateEvent and calls Update on EventHandler
// OnUpdate creates UpdateEvent and calls Update on EventHandler
func (e EventHandler) OnUpdate(oldObj, newObj interface{}) {
u := event.UpdateEvent{}

Expand Down Expand Up @@ -124,7 +124,7 @@ func (e EventHandler) OnUpdate(oldObj, newObj interface{}) {
e.EventHandler.Update(u, e.Queue)
}

// OnDelete creates and DeleteEvent and calls Delete on EventHandler
// OnDelete creates DeleteEvent and calls Delete on EventHandler
func (e EventHandler) OnDelete(obj interface{}) {
d := event.DeleteEvent{}

Expand Down