Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ update kubernetes 1.13 to the latest patch release #349

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

tariq1890
Copy link

@tariq1890 tariq1890 commented Mar 5, 2019

It is in the best interests of any k8s API consumer that we always vendor in the latest patch release of a minor version.

As controller-runtime acts as the primary source of k8s-dependencies for cluster-API and its providers, best practices mandate that we update the versions at the root so that they percolate down to the Cluster API providers. If this change is not accepted, we would be forced to use override deps.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2019
@tariq1890
Copy link
Author

@detiber Can we push this in pretty please :) ?

@vincepri
Copy link
Member

vincepri commented Mar 5, 2019

@tariq1890 The PR title should be prefixed with ✨ given that this is a backward compatible change.

/assign @DirectXMan12

@tariq1890 tariq1890 changed the title update kubernetes 1.13 to the latest patch release ✨ update kubernetes 1.13 to the latest patch release Mar 5, 2019
@detiber
Copy link
Member

detiber commented Mar 5, 2019

/assign @fanzhangio

@tariq1890
Copy link
Author

/assign @k8s-ci-robot

@k8s-ci-robot k8s-ci-robot self-assigned this Mar 5, 2019
@DirectXMan12
Copy link
Contributor

Can you please add a PR description motivating this change -- it's useful for looking back at the merge history to see why something was particularly relevant.

@DirectXMan12
Copy link
Contributor

(even just something like "1.13.4 includes a fix for bug XYZ that affects CR users when they do foo")

@tariq1890
Copy link
Author

@DirectXMan12 I've mentioned the reason.

@tariq1890
Copy link
Author

Any updates on this?

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3cbf52b into kubernetes-sigs:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants