🏃 add tests for simplified webhook interface #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @DirectXMan12 |
DirectXMan12
suggested changes
Mar 12, 2019
pkg/builder/build_test.go
Outdated
|
|
||
| By("trying to register an existing mutating webhook path") | ||
| path := generateMutatePath(schema.GroupVersionKind{Group: "foo.test.org", Version: "v1", Kind: "TestDefaulter"}) | ||
| Ω(func() { svr.Register(path, nil) }).Should(Panic()) |
There was a problem hiding this comment.
this is a bit of a weak test -- what if we add validation that handler is not nil, or something? Maybe we should check that it responds to a valid admission request?
mengqiy
force-pushed
the
simplifywhif_tests
branch
from
901b6f8
to
157eb42
Compare
k8s-ci-robot
added
size/XL
mengqiy
force-pushed
the
simplifywhif_tests
branch
from
157eb42
to
cd6fa1a
Compare
mengqiy
force-pushed
the
simplifywhif_tests
branch
from
cd6fa1a
to
ad30658
Compare
|
/lgtm We'll need to resolve the dep management issue at some point, but this is fine for now. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Thirdparty tools to use k8s 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR per #328 (comment)