-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ pkg/manager,metrics: Expose ServingMetrics func #367
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiliC If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
598f775
to
609d7d9
Compare
609d7d9
to
be41b4d
Compare
Noticed once the unit tests failed, but reran the job and they passed. Not sure if this is a documented flake? Don't think it's introduced with this PR? It was the |
From #337 (comment):
I propose a slightly different interface: Create a We've been experimenting with this in Knative here where we have two Runnable http servers (one for metrics) managed by the Manager. (note the use of a waitgroup is only required because of #350). It's also relevant for #305, where we may have multiple metrics exporters running in the process. |
That works for our use case very well for our use cases as well. Would be happy to implement that if everyone agrees on it. 👍 |
That seems pretty reasonable. I'd still like to have "metrics by default" where you can explicitly disable them, but making it a runnable seems fine. |
Okay, will close this PR and we can discuss the details in the #336 |
cloudbuild configs to use k8s 1.11
Exposes
ServingMetrics()
function and moves it to the metrics package, so serving metrics can be done independently of calling.Start()
.Implemented as per the suggestion from this comment.
Closes #336
cc @DirectXMan12