Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰Fix used scheme for fake client in List method #380

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Apr 1, 2019

Description

Changes proposed in this pull request:

  • Really simple fix for used scheme in fake client in List method.

Background

This bug #137 was already fixed by this PR: #213. Unfortunately in this PR the bug was reintroduced - probably by mistake.

NOTE:
I also tried to change the tests to never regress but such action will complicate the test suite, so IMO is really not worth to do that. But if you think that tests coverage should be added then let's decide which types should be used and how the test suite should look like, e.g. full tests for NewFakeClientWithScheme and only one test for NewFakeClient ensuring that it's injecting the "k8s.io/apimachinery/pkg/runtime/schema.Scheme"? If the decision will be made then I can implement that too :)

Related issue

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2019
@grantr
Copy link
Contributor

grantr commented Apr 1, 2019

Unfortunately in this PR the bug was reintroduced - probably by mistake.

Good catch! This may have been accidentally introduced if the code from #294 was copied from #106 (which was written before #213).
/cc @droot

@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b58294f into kubernetes-sigs:master Apr 2, 2019
@mszostok mszostok deleted the fix-fake-cli branch July 2, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants