Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Populate GVK for listed objects #389

Merged
merged 4 commits into from
May 15, 2019
Merged

🐛 Populate GVK for listed objects #389

merged 4 commits into from
May 15, 2019

Commits on May 8, 2019

  1. Populate GVK for listed objects

    @liyinan926 @JoelSpeed
    liyinan926 authored and JoelSpeed committed May 8, 2019
    Configuration menu
    Copy the full SHA
    839d5aa View commit details
    Browse the repository at this point in the history

  2. Check that the right GVK gets populated

    @liyinan926 @JoelSpeed
    liyinan926 authored and JoelSpeed committed May 8, 2019
    Configuration menu
    Copy the full SHA
    88f5187 View commit details
    Browse the repository at this point in the history

  3. Account for regular cache and multinamespaced cache in List GVK test

    @JoelSpeed
    JoelSpeed committed May 8, 2019
    Configuration menu
    Copy the full SHA
    8f8b3f5 View commit details
    Browse the repository at this point in the history

  4. Copy object before modifying it 

    Otherwise you can get races when getting and listing simultaneously
    @JoelSpeed
    JoelSpeed committed May 8, 2019
    Configuration menu
    Copy the full SHA
    fc22506 View commit details
    Browse the repository at this point in the history