Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ envtest can load multiple CRDs from single file #397

Merged
merged 1 commit into from
May 10, 2019
Merged

✨ envtest can load multiple CRDs from single file #397

merged 1 commit into from
May 10, 2019

Conversation

GrigoriyMikhalkin
Copy link
Contributor

Updatedenvtests to support loading multiple CRDs from single file

Fixes #369

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 13, 2019
@GrigoriyMikhalkin
Copy link
Contributor Author

I signed it

@GrigoriyMikhalkin
Copy link
Contributor Author

/assign @DirectXMan12

mengqiy
mengqiy reviewed May 8, 2019
View reviewed changes
Copy link
Member

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

pkg/envtest/multiplecrds.yaml Outdated
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
name: firsts.first.example.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firsts.first.example.com and seconds.second.example.com looks very weird.
I'd suggest captains.crew.example.com and firstmates.crew.example.com. These are something we use a lot in kubebuilder testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR

@mengqiy
Copy link
Member

mengqiy commented May 8, 2019

@GrigoriyMikhalkin sorry for the late review

@GrigoriyMikhalkin GrigoriyMikhalkin force-pushed the issue/369 branch 2 times, most recently from d048e2a to 794235d Compare May 9, 2019 11:31
@mengqiy
Copy link
Member

mengqiy commented May 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2019
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: GrigoriyMikhalkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2c5bca2 into kubernetes-sigs:master May 10, 2019
@GrigoriyMikhalkin GrigoriyMikhalkin mentioned this pull request Jun 11, 2019
Closed
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@droot
Merge pull request #397 from fanzhangio/gitbook
4edfc1f 
Add subresource annotation documents in gitbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy mengqiy left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Envtest: support loading multiple CRDs from a single file
4 participants
@GrigoriyMikhalkin @k8s-ci-robot @mengqiy @DirectXMan12