✨ Implement IgnoreNotFound
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/assign @DirectXMan12 |
Closed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adracus, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@adracus Travis is failing, please fix |
implement `IgnoreNotFound` that ignores `NotFound` errors create test cases
adracus
force-pushed
the
feature.ignore-not-found
branch
from
24ce9a4
to
794ef6d
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
Don't really know why this now immediately got merged... I just fixed the build locally, then the Travis build failed since the PR was already closed |
|
Ok however the merge commit's build passed: |
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Add missing type to ContainerSetStatus example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement
IgnoreNotFoundthat ignoresNotFounderrorscreate test cases
Fixes #357
This allows to easily ignore
NotFounderrors which is often required in case where it's just necessary to see that a resource is gone.