Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Minimal Apply Support, Fix Up Client Options #435

Merged
merged 4 commits into from
May 17, 2019
Merged

⚠️ Minimal Apply Support, Fix Up Client Options #435

merged 4 commits into from
May 17, 2019

Commits on May 17, 2019

  1. Server Side Apply Patch Type 

    This introduces a patch type for server-side apply, and the associated
patch options.
    @DirectXMan12
    DirectXMan12 committed May 17, 2019
    Configuration menu
    Copy the full SHA
    bc64d91 View commit details
    Browse the repository at this point in the history

  2. Add server-side apply options 

    This adds patch options related to server-side apply, and moves options
to their own file.
    @DirectXMan12
    DirectXMan12 committed May 17, 2019
    Configuration menu
    Copy the full SHA
    5e7ec24 View commit details
    Browse the repository at this point in the history

  3. Switch functional options with no args to vars 

    This switches functional arguments with no variables to not taking
arguments, meaning that they can be called like

```go
r.Update(ctx, obj, client.UpdateDryRunAll)
```

instead of

```go
r.Update(ctx, obj, client.UpdateDryRunAll())
```

Options with arguments still get called as functions.
    @DirectXMan12
    DirectXMan12 committed May 17, 2019
    Configuration menu
    Copy the full SHA
    f4eaa7b View commit details
    Browse the repository at this point in the history

  4. Add PatchStatus, options to UpdateStatus 

    This adds .Status().Patch to the client for patching status, and makes sure
that .Status().Update takes update options like normal update does.
    @DirectXMan12
    DirectXMan12 committed May 17, 2019
    Configuration menu
    Copy the full SHA
    36db6ad View commit details
    Browse the repository at this point in the history