Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update Kubernetes to 1.13.4 [release-0.1] #473

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jun 5, 2019

Signed-off-by: Vince Prignano vincepri@vmware.com

This PR updates this repository's dependencies to 1.13.4, this is mainly to match controller-tools latest release, which is already at this version.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2019
@vincepri
Copy link
Member Author

vincepri commented Jun 5, 2019

To give more context, when I tried to use constraints with controller-runtime@0.1.11 and controller-tools@0.1.10, dep complained about the Kubernetes version mismatch.

Solving failure: No versions of sigs.k8s.io/controller-tools met constraints:
        v0.1.10: Could not introduce sigs.k8s.io/controller-tools@v0.1.10, as it has a dependency on k8s.io/api with constraint kubernetes-1.13.4, which has no overlap with existing constraint kubernetes-1.13.1 from sigs.k8s.io/controller-runtime@v0.1.11

@vincepri
Copy link
Member Author

vincepri commented Jun 5, 2019

/assign @DirectXMan12

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit f1eaba5 into kubernetes-sigs:release-0.1 Jun 6, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Controller example in gitbook does not work due to wrong Reconcile
function. This patch updates the function.

Fixes #473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants