✨ enable conversion webhook in webhook builder #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
mengqiy
reviewed
Jun 27, 2019
| @@ -247,32 +248,45 @@ func CheckConvertibility(scheme *runtime.Scheme, obj runtime.Object) error { | |||
| } | |||
|
|
|||
| if len(gvks) == 1 { | |||
| return nil // single version | |||
| return false, nil // single version | |||
| } | |||
|
|
|||
| if len(hubs) == 0 && len(spokes) == 0 { | |||
| // multiple version detected with no conversion implementation. This is | |||
There was a problem hiding this comment.
IMO we should log something in this case, since builtin types won't be sent to the webhoo; If it happens it usually means CRD conversion are configured by the CRD types doesn't implement Hub and Convertible interfaces.
Feel free to address this in a followup PR.
|
And please also fix the linter failure. |
droot
force-pushed
the
feature/enable-conversion-webhook
branch
from
d5d4e71
to
bbfa3a4
Compare
Main changes: - Disable conversion webhook by default and enable only if a type implements convertible - Enhanced the test coverage to include spoke to spoke conversion
droot
force-pushed
the
feature/enable-conversion-webhook
branch
from
bbfa3a4
to
0f2e574
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Add a script to test installation script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
implements convertible