Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 ff release-0.2 branch to master HEAD #512

Merged
merged 8 commits into from
Jul 2, 2019
Merged

🏃 ff release-0.2 branch to master HEAD #512

merged 8 commits into from
Jul 2, 2019

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jul 2, 2019

Prepare for next CR beta release.

adohe and others added 8 commits June 13, 2019 11:57
@adohe
🐛 fix runnable run twice issue
e63210a
@sbueringer
add GetConfigWithContext to retrieve a config with a specific context
8e131cc
@k8s-ci-robot
Merge pull request #487 from adohe/fix_runnable_twice
28262f4 
🐛 fix runnable run twice issue
@k8s-ci-robot
Merge pull request #489 from sbueringer/add-getconfig-with-context
4c81828 
✨ add GetConfigWithContext to retrieve a config with a specific context
🐛 IsConvertible should not error on uninitialized struct.
9f5b249 
IsConvertible used to use obj.GetObjectKind().GroupVersionKind() to get
GVK which will not work if apiVersion and kind fields are not set. Now
it uses scheme.ObjectKinds(obj).
@k8s-ci-robot
Merge pull request #508 from mengqiy/fixIsConvetible
da24e0f 
🐛 IsConvertible should not error on uninitialized struct.
⚠️ metrics are now on by default
410863e
@k8s-ci-robot
Merge pull request #510 from mengqiy/metricsdefault
2495fdd 
⚠️ metrics are now on by default
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2019
@mengqiy mengqiy requested a review from DirectXMan12 July 2, 2019 20:13
@droot droot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mengqiy
Copy link
Member Author

mengqiy commented Jul 2, 2019 •
edited
Loading

Travis apparently has a huge backlog: https://www.traviscistatus.com/incidents/g9xm3l02dknv
This is all from master HEAD which is already tested.

the backlog on .org is over its peak.

They updated the status 10 minutes ago.
I'm not sure if we really need to wait for Travis to become normal.

@droot
Copy link
Contributor

droot commented Jul 2, 2019

I'm not sure if we really need to wait for Travis to become normal.

We can merge it manually. But lets run tests locally before cutting the release.

@droot droot merged commit aaddbd9 into release-0.2 Jul 2, 2019
@2uasimojo 2uasimojo mentioned this pull request Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mengqiy @k8s-ci-robot @droot @adohe @sbueringer