-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests #52
Added tests #52
Conversation
seans3
commented
Jun 19, 2018
- Added "List" tests
- Added "ListOptions" tests
- Coverage is now 93.0%
/assign droot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Expect(1).To(Equal(len(deps.Items))) | ||
actual := deps.Items[0] | ||
Expect(actual.Name).To(Equal("deployment-frontend")) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great if we can can another List() call here for all-namespaces
and we get both the deployments. That will cover all the namespace based filtering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, lets follow up with that
/lgtm |