-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 surface controller options when using builder #520
Conversation
Welcome @awesomenix! |
For future reference: try to avoid github handles in PR messages, since they'll trigger notifications every time the commit moves around in a fork. |
hmm... can we future proof this so additional fields don't need extra work? |
Fixes: #317 - Currently there is no way to override MaxConcurrentReconciles using builder - Provide a method to override controller options - Another approach was to provide MaxConcurrentReconciles itself, but it isnt future proof incase additional options are added
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awesomenix, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
.gitignore: Add temp files
Fixes: #317