Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Preserve GroupVersionKind during Update/Patch #528

Merged
merged 1 commit into from
Jul 27, 2019
Merged

🐛 Preserve GroupVersionKind during Update/Patch #528

merged 1 commit into from
Jul 27, 2019

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano vincepri@vmware.com

Fixes #526
Fixes #406

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2019
@vincepri vincepri force-pushed the fixup-gvk branch 3 times, most recently from 5553ddf to eea9633 Compare July 22, 2019 17:09
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2019
@vincepri
Copy link
Member Author

/check-cla

@vincepri
Copy link
Member Author

/assign @DirectXMan12

@DirectXMan12
Copy link
Contributor

this looks good at a glance. Do we know why it's getting cleared in the first place?

@vincepri
Copy link
Member Author

I haven't looked deeper than here, I can try to take a look upstream

@vincepri
Copy link
Member Author

It seems like it's because of https://github.com/kubernetes/apimachinery/blob/6a84e37a896db9780c75367af8d2ed2bb944022e/pkg/runtime/serializer/versioning/versioning.go#L279

which seems fixed in a later version of apimachinery

@vincepri
Copy link
Member Author

I'll add a TODO to remove this in 1.15

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Jul 24, 2019 •
edited
Loading

can you add your name to the TODO (I should add a linter for this) -- we follow the convention of // TODO(person-who-might-have-any-idea-of-why-this-is): message about a thing (or just file a bug and put the bug number instead of your name) -- it helps to keep around context.

Otherwise looks fine

@vincepri vincepri force-pushed the fixup-gvk branch 2 times, most recently from 7beb556 to bd44622 Compare July 24, 2019 14:56
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 24, 2019
@vincepri
Copy link
Member Author

@DirectXMan12 Fixed up, I'll take care of removing this when 1.15 is out

@vincepri
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@vincepri
🐛 Preserve GroupVersionKind during Update/Patch
cea57be 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2019
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit ee41a80 into kubernetes-sigs:master Jul 27, 2019
@chuckha chuckha mentioned this pull request Aug 13, 2019
Merged
@kaczyns kaczyns mentioned this pull request Oct 14, 2019
Closed
@negz negz mentioned this pull request Mar 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object loses TypeMeta after Patch BUG: client.UpdateStatus.Update() func clears Kind of the local object
4 participants
@vincepri @fejta-bot @DirectXMan12 @k8s-ci-robot