Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Functional Options Redux #536

Merged
merged 2 commits into from
Jul 25, 2019
Merged

⚠️ Functional Options Redux #536

merged 2 commits into from
Jul 25, 2019

Commits on Jul 24, 2019

  1. Switch to interface-based options 

    These behave more-or-less like functional options, except that a given
option can be applied to more than on option type, so we can deprecate
the 3 different dryrunall variants.

Things with arguments generally become type aliases, with the exception
of MatchingField, which gets deprecated in favor of MatchFields (a type
alias to fields.Set).
    @DirectXMan12
    DirectXMan12 committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    68d92bb View commit details
    Browse the repository at this point in the history

  2. Add field manager & dryrun to other opts 

    For field manager, update and create also support fieldmanager, so we
allow using them there.

For dryrun, it's also supported by delete, so we support setting it
there.
    @DirectXMan12
    DirectXMan12 committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    320b6b6 View commit details
    Browse the repository at this point in the history