✨ Pass HTTP request Context through to admission Webhook handlers

[seh]

Rather than synthesizing a fresh context.Context for each admission Webhook request, instead pass through a Context obtained from the original http.Request passed in to the http.Handler. This way, we can wrap middleware http.Handlers around the webhook.Admission handlers, such as those that establish tracing spans, instrumentation, or logging context, and have our admission.Handlers continue to use that same context.

Note that if an http.Request had no Context bound explicitly with http.WithContext, the Request.Context method returns context.Background.

[k8s-ci-robot]

Welcome @seh!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[DirectXMan12]

good catch, thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, seh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seh]

In proxy server terms, the inner handlers are analogous to "upstream" servers. Given that, if my use of "downstream" is confusing, please let me know and I can try again.

[DirectXMan12]

eh, I think it's clear enough if you're vaguely familiar with context. We'll see if anyone complains :-)