Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed field selector test #55

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fixed field selector test #55

merged 1 commit into from
Jun 21, 2018

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 21, 2018

Fixes one of the commented out tests -- field selector test.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2018
@seans3 seans3 self-assigned this Jun 21, 2018
@seans3
Copy link
Contributor Author

seans3 commented Jun 21, 2018

/assign droot
/assign pwittrock

@droot droot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 42c37db into kubernetes-sigs:master Jun 21, 2018
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#55 from seans3/client-tests
4151248 
Fixed field selector test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

Assignees

@droot droot

@seans3 seans3

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @droot @pwittrock @k8s-ci-robot