-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Add script to run tests in Prow #581
Conversation
0d4e48a
to
aecc751
Compare
aecc751
to
8acf71d
Compare
Requires kubernetes/test-infra#14162 to merge, so we can verify this works. I tested this on a different Prow instance so I am reasonably confident there wont be issues. Should I already remove the /assign @DirectXMan12 |
yeah, let's get mandatory presubmit merged before we remove travis. Better to run tests twice than not at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, otherwise lgtm
hack/ci-check-everything.sh
Outdated
( | ||
# Doesn't work with gomodules turned on, see https://github.com/golang/dep/issues/2055 | ||
export GO111MODULE=off | ||
go get -u github.com/golang/dep/cmd/dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just be downloading the compiled binary here? Prob way quicker.
8acf71d
to
ef03625
Compare
@DirectXMan12 updated the script to install a binary version of Could you also have a look on the pull in test-infra? It adds the new presubmit as optional, so it is safe to merge already. Once it is merged, we can verify here if everything works :) |
yep, looked at it. Looks like @droot isn't in the kubernetes org, but otherwise LGTM |
hold off on approving this till that merges? |
/test pull-controller-runtime-test |
ef03625
to
0421398
Compare
/test pull-controller-runtime-test |
1 similar comment
/test pull-controller-runtime-test |
Okay, so the presubmit passed, with a timeout on the first attempt. My best guess as why that happens is CPU starvation, which is why I opened kubernetes/test-infra#14184 to make the job request CPU. IMHO this is good to go, PTAL |
/lgtm awesome excited for this |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds a script to run tests in Prow. Done to resolve #276