Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gnostic to v0.2.2 #597

Closed
wants to merge 1 commit into from
Closed

Update gnostic to v0.2.2 #597

wants to merge 1 commit into from

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Sep 10, 2019

This is the same commit as v0.2.0 but since v0.2.2 is past the zombie v0.2.1 release go module patch upgrades work correctly.

/assign @DirectXMan12

If we accept this can we tag it as v0.2.1?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fejta
To complete the pull request process, please assign pwittrock
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2019
@fejta
Copy link
Contributor Author

fejta commented Sep 10, 2019

Alternatively we could tag master as v0.3.0 or v0.2.1, but this will be the smallest change

@DirectXMan12
Copy link
Contributor

since gnostic isn't in our public API anywhere, just tagging master as v0.2.1 should be fine (see #596 )

@fejta fejta closed this Sep 10, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Fix typo in init_project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants