Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Bump to kube-1.16.0 #618

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 30, 2019

Bump to kubernetes-1.16.0 just in case #588 is not updated

@k8s-ci-robot
Copy link
Contributor

Welcome @enxebre!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @enxebre. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gerred
Copy link
Contributor

gerred commented Oct 4, 2019

@DirectXMan12 @pwittrock

@kensipe and I have some cycles to help shepherd and test this and get everything ready to release this update as we need it for KUDO. What would help you most in launching this? Are there other PRs/issues that need to land as well that we can take on?

Thanks! Happy to chat about it in Slack/Zoom/next SIG API Machinery meeting as well.

@gerred
Copy link
Contributor

gerred commented Oct 4, 2019

Also what does this mean for generation wrt controller-tools/kubebuilder - does Kubebuilder need to generate out CustomResourceDefinition/v1 instead of v1beta1 after this lands? Is there a delay/compat period for this that's needed?

@gerred
Copy link
Contributor

gerred commented Oct 9, 2019

This works and lgtm.

@enxebre enxebre force-pushed the kube-1.16.0 branch 2 times, most recently from 3193763 to ecbeb5a Compare October 10, 2019 07:43
@enxebre
Copy link
Member Author

enxebre commented Oct 10, 2019

Albertos-MacBook-Pro:controller-runtime@albertogarla $ go vet ./...
Albertos-MacBook-Pro:controller-runtime@albertogarla $
Albertos-MacBook-Pro:controller-runtime@albertogarla $ go test ./...
ok  	sigs.k8s.io/controller-runtime	(cached) [no tests to run]
?   	sigs.k8s.io/controller-runtime/examples/builtins	[no test files]
?   	sigs.k8s.io/controller-runtime/examples/crd	[no test files]
?   	sigs.k8s.io/controller-runtime/examples/crd/pkg	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/builder	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/cache	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/cache/informertest	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/cache/internal	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/client	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/client/apiutil	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/client/config	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/client/fake	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/controller	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/controller/controllertest	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/controller/controllerutil	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/conversion	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/envtest	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/envtest/printer	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/event	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/handler	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/internal/controller	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/internal/controller/metrics	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/internal/log	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/internal/objectutil	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/internal/recorder	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/leaderelection	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/leaderelection/fake	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/log	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/log/zap	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/manager	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/manager/signals	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/metrics	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/patterns/application	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/patterns/operator	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/predicate	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/reconcile	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/reconcile/reconciletest	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/recorder	(cached) [no tests to run]
?   	sigs.k8s.io/controller-runtime/pkg/runtime	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/runtime/inject	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/runtime/log	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/runtime/scheme	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/runtime/signals	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/scheme	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/source	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/source/internal	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/webhook	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/webhook/admission	(cached)
ok  	sigs.k8s.io/controller-runtime/pkg/webhook/conversion	(cached)
?   	sigs.k8s.io/controller-runtime/pkg/webhook/internal/certwatcher	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/webhook/internal/metrics	[no test files]
Albertos-MacBook-Pro:controller-runtime@albertogarla $ go-apidiff v0.2.2 kube-1.16.0

sigs.k8s.io/controller-runtime/examples/crd/pkg
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *ChaosPod: removed
  - (*ObjectMeta).SetInitializers, method set of *ChaosPod: removed
  - ChaosPod.Initializers: removed
Albertos-MacBook-Pro:controller-runtime@albertogarla $ go-apidiff v0.2.2 kube-1.16.0  --compare-imports

sigs.k8s.io/controller-runtime/examples/crd/pkg
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *ChaosPod: removed
  - (*ObjectMeta).SetInitializers, method set of *ChaosPod: removed
  - ChaosPod.Initializers: removed

k8s.io/api/core/v1
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *Event: removed
  - (*ObjectMeta).GetInitializers, method set of *PodTemplateSpec: removed
  - (*ObjectMeta).SetInitializers, method set of *Event: removed
  - (*ObjectMeta).SetInitializers, method set of *PodTemplateSpec: removed
  - Event.Initializers: removed
  - PodTemplateSpec.Initializers: removed

k8s.io/apimachinery/pkg/apis/meta/v1
  Incompatible changes:
  - (*ObjectMeta).GetInitializers: removed
  - (*ObjectMeta).SetInitializers: removed
  - Fields: removed
  - Initializer: removed
  - Initializers: removed
  - ListInterface.GetRemainingItemCount: added
  - ListInterface.SetRemainingItemCount: added
  - ManagedFieldsEntry.Fields: removed
  - Object.GetInitializers: removed
  - Object.SetInitializers: removed
  - ObjectMeta.Initializers: removed

k8s.io/apimachinery/pkg/runtime
  Incompatible changes:
  - Unstructured.NewEmptyInstance: added

k8s.io/apimachinery/pkg/util/sets
  Incompatible changes:
  - String.Delete: changed from func(...string) to func(...string) String
  - String.Insert: changed from func(...string) to func(...string) String

k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *CustomResourceDefinition: removed
  - (*ObjectMeta).SetInitializers, method set of *CustomResourceDefinition: removed
  - CustomResourceDefinition.Initializers: removed
Albertos-MacBook-Pro:controller-runtime@albertogarla $
Albertos-MacBook-Pro:controller-runtime@albertogarla $ go-apidiff origin/master kube-1.16.0

sigs.k8s.io/controller-runtime/examples/crd/pkg
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *ChaosPod: removed
  - (*ObjectMeta).SetInitializers, method set of *ChaosPod: removed
  - ChaosPod.Initializers: removed
Albertos-MacBook-Pro:controller-runtime@albertogarla $ go-apidiff origin/master kube-1.16.0 --compare-imports

sigs.k8s.io/controller-runtime/examples/crd/pkg
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *ChaosPod: removed
  - (*ObjectMeta).SetInitializers, method set of *ChaosPod: removed
  - ChaosPod.Initializers: removed

k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *CustomResourceDefinition: removed
  - (*ObjectMeta).SetInitializers, method set of *CustomResourceDefinition: removed
  - CustomResourceDefinition.Initializers: removed

k8s.io/apimachinery/pkg/util/sets
  Incompatible changes:
  - String.Delete: changed from func(...string) to func(...string) String
  - String.Insert: changed from func(...string) to func(...string) String

k8s.io/api/core/v1
  Incompatible changes:
  - (*ObjectMeta).GetInitializers, method set of *Event: removed
  - (*ObjectMeta).GetInitializers, method set of *PodTemplateSpec: removed
  - (*ObjectMeta).SetInitializers, method set of *Event: removed
  - (*ObjectMeta).SetInitializers, method set of *PodTemplateSpec: removed
  - Event.Initializers: removed
  - PodTemplateSpec.Initializers: removed

k8s.io/apimachinery/pkg/apis/meta/v1
  Incompatible changes:
  - (*ObjectMeta).GetInitializers: removed
  - (*ObjectMeta).SetInitializers: removed
  - Fields: removed
  - Initializer: removed
  - Initializers: removed
  - ManagedFieldsEntry.Fields: removed
  - Object.GetInitializers: removed
  - Object.SetInitializers: removed
  - ObjectMeta.Initializers: removed

@enxebre
Copy link
Member Author

enxebre commented Oct 10, 2019

@marun @DirectXMan12 rebased and run go-apidiff

@DirectXMan12
Copy link
Contributor

cool, looks good. Holding till we release the 1.15 version (prob later today)

@DirectXMan12
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2019
@DirectXMan12
Copy link
Contributor

/unhold

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Oct 10, 2019

so... technically this is breaking due to a field removal in CRDs, which are exposed in pkg/envtest/crd. v0.4.0 it is for this, then

@DirectXMan12 DirectXMan12 changed the title Bump to kube-1.16.0 ⚠️ Bump to kube-1.16.0 Oct 10, 2019
@DirectXMan12
Copy link
Contributor

let's maybe do 1.13 as Min Go Version in 0.4.0 as well.

@enxebre
Copy link
Member Author

enxebre commented Oct 11, 2019

so... technically this is breaking due to a field removal in CRDs, which are exposed in pkg/envtest/crd. v0.4.0 it is for this, then

hey @DirectXMan12 you mind pointing me to that field?

let's maybe do 1.13 as Min Go Version in 0.4.0 as well.

ok cool, I'll update the PR for 1.13

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2019
@DirectXMan12
Copy link
Contributor

There should already be a 1.13 bump PR around -- #606. Just listing it out so where aware. They can merge separately.

The fields removed are the Initializer-related fields. They show up in ObjectMeta, which shows up in CustomResourceDefinition, which shows up in pkg/envtest.CRDInstallOptions.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2019
@enxebre
Copy link
Member Author

enxebre commented Oct 11, 2019

@DirectXMan12 rebased

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@njhale
Copy link

njhale commented Oct 13, 2019

This is still being held. It looks like the intent was to cancel the hold earlier (see comment), but it doesn't seem like /unhold did the trick.

@enxebre
Copy link
Member Author

enxebre commented Oct 14, 2019

yep seems still needs /hold cancel and /ok-to-test I don't have perms here.
cc @DirectXMan12

@DirectXMan12
Copy link
Contributor

whoops lol

/hold cancel
/ok-to-test

/secret-switch-to-enable-prow-to-do-what-I-actually-mean-in-the-future :-P

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2df793d into kubernetes-sigs:master Oct 16, 2019
@gerred
Copy link
Contributor

gerred commented Oct 16, 2019

@kensipe @alenkacz Christmas has come!

enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Oct 23, 2019
We were pointing to a dead commit of a fork with kube 1.16. We can now point back to canonical repo now this is merged kubernetes-sigs/controller-runtime#618
enxebre added a commit to enxebre/machine-api-operator that referenced this pull request Oct 24, 2019
We were pointing to a dead commit of a fork with kube 1.16. We can now point back to canonical repo now this is merged kubernetes-sigs/controller-runtime#618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants