-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Avoid extra deep copy in CacheReader.List #625
✨ Avoid extra deep copy in CacheReader.List #625
Conversation
Welcome @charith-elastic! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @charith-elastic. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
/check-cla |
/ok-to-test Nice change, thanks for doing it! Should you have time for that it would be nice to have some tests that verify that LabelSelector work properly here. But that didn't exist before your change either. |
I think there are some label selector tests for the cache that ends up exercising the code here. The coverage report indicates that this bit is covered pretty well. If you have any suggestions about additional tests that should be added, I'll be happy to look into those. /check-cla |
Oh right, I guess that's fine then, I just saw the missing tests in the packages themselves when reviewing. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charith-elastic, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CacheReader.List
method creates deep copies of objects retrieved from the index and then passes them on toobjectutil.FilterWithLabels
which again deep copies objects matching the label selector. This PR inlines the label filtering logic to avoid the double deep copy.Fixes #621