Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] ⚠️ Secure Serving & Webhook Support in envtest #645

Closed
wants to merge 1 commit into from
Closed

[wip] ⚠️ Secure Serving & Webhook Support in envtest #645

wants to merge 1 commit into from

Conversation

DirectXMan12
Copy link
Contributor

This is currently a prototype -- the code is pretty terribly organized

I've hacked together support for testing webhooks in envtest. Along the way, I also added support for authn in envtest, which will eventually become necessary when we have to stop using the insecure port and switch to the secure port.

This is pretty hacky, and includes all of testing_frameworks (as suggested in kubernetes-retired/testing_frameworks#68), but I wanted to get it up just in case people were interested.

I might not have time to clean it up soon, but will most likely get back to it eventually.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DirectXMan12
Copy link
Contributor Author

/kind feature
/hold

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2019
@DirectXMan12 DirectXMan12 added the experiment This is an experiment around the shape of an API label Dec 3, 2019
This was referenced Dec 3, 2019
Closed
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

@DirectXMan12: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-controller-runtime-test a7a2352 link /test pull-controller-runtime-test
pull-controller-runtime-test-master a7a2352 link /test pull-controller-runtime-test-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Feb 1, 2020
Merged
Closed
@DirectXMan12
Copy link
Contributor Author

gonna close this one, partially picked up in #787, secure serving bits need a new owner though.

@DirectXMan12 DirectXMan12 added the out-of-time-pick-me-up Someone ran out of time, feel free to pick this up label Feb 5, 2020
@DirectXMan12 DirectXMan12 mentioned this pull request Aug 17, 2020
Closed
@DirectXMan12 DirectXMan12 mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. experiment This is an experiment around the shape of an API kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. out-of-time-pick-me-up Someone ran out of time, feel free to pick this up size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DirectXMan12 @k8s-ci-robot @fejta-bot