Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 use semantic equality in CreateOrUpdate #704

Merged
merged 1 commit into from
Dec 3, 2019
Merged

🐛 use semantic equality in CreateOrUpdate #704

merged 1 commit into from
Dec 3, 2019

Conversation

alexeldeib
Copy link
Contributor

plucking some low hanging fruit

fixes #464

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2019
@alexeldeib
Copy link
Contributor Author

server side apply is probably better here, actually.

/close

@alexeldeib alexeldeib closed this Dec 2, 2019
@DirectXMan12
Copy link
Contributor

We should probably do both, actually. This is a pretty easy fix for some weird issues.

@alexeldeib
Copy link
Contributor Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@alexeldeib: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Dec 3, 2019
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeldeib, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit fee132e into kubernetes-sigs:master Dec 3, 2019
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #704 from droot/running/switch-to-go-modules
fbf8a02 
🏃 switch to using Go modules in build tooling
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot @droot
Merge pull request #704 from droot/running/switch-to-go-modules
ed46300 
🏃 switch to using Go modules in build tooling
@tlwr tlwr mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@droot droot Awaiting requested review from droot

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@alexeldeib @DirectXMan12 @k8s-ci-robot