⚠️ Envtest: Do not pull in ginkgo outside of _test.go files

[alvaroaleman]

I noticed that introducing envtest as a dependency also adds ginkgo as a transient dependency, this PR fixes that.

/assign @DirectXMan12

[DirectXMan12]

This is a breaking change. We actually meant to make this a while ago, IIRC, but never got around to finalizing the breaking change.

I'm fine with doing this, but let's leave it for the next set of breaking changes.

[DirectXMan12]

/hold

[vincepri]

This should be good to go as well, we might need to retitle to make it a ⚠️ / breaking change for users

/hold cancel
/lgtm
/assign @gerred @DirectXMan12

[DirectXMan12]

IIRC, this has been deprecated for a while, but is a ⚠️ none-the-less. Updating

[DirectXMan12]

ooo, this is gonna be a bit painful b/c it hits test suites.

we need to update KB to start scaffolding new projects with this change too.

[DirectXMan12]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

/retest

[gerred]

kicking off one retest bc this is a type alias and shouldn't trigger random timeouts.

this should be generally OK though in KB and elsewhere though until we remove the type alias, yeah?

/retest