-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Merge patch type and deprecate ConstantPatch in favor of RawPatch #721
Conversation
Welcome @Adirio! |
Hi @Adirio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @DirectXMan12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, otherwise lgtm
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@DirectXMan12 requested changes addressed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scaffold/v2/group: fix comment capitalization for golint
Adds a new patch type called
Merge
for simple patch operations and renamesConstantPatch
in favor ofRawPatch
(new name). Motivation and discussion can be found in the related issue.Closes #665