-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ client: Use dynamic RESTMapper by default #737
✨ client: Use dynamic RESTMapper by default #737
Conversation
This commit changes the client package to use the dynamic RESTMapper by default. The default RESTMapper caches the discovery endpoint results once and never updates them. Because of that, if an api-resource is added after the client is started, the client will mistakenly think the api-resource doesn't exist. Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Welcome @yanniszark! |
Hi @yanniszark. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@alenkacz thanks for the review :) |
/ok-to-test |
updated to ✨ because this is more of a feature introduction (even if we intended to turn it on originally). |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, yanniszark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #734
This commit changes the client package to use the dynamic RESTMapper by
default.
The default RESTMapper caches the discovery endpoint results once and
never updates them.
Because of that, if an api-resource is added after the client is
started, the client will mistakenly think the api-resource doesn't exist.
Signed-off-by: Yannis Zarkadas yanniszark@arrikto.com