-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add httpserver.Server and pkg/debug
for pprof support
#743
✨ Add httpserver.Server and pkg/debug
for pprof support
#743
Conversation
The idea is to have an `Http.Server` as a manager.Runnable component On which other components can register `http.Handler`. The main benefice is to have only one http.Listener with multiples "handlers": * Add new httpserver.Server Runnable component * Add metrics handler registration function * Add debug package with pprof Handler registration function Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
Welcome @clamoriniere! |
Hi @clamoriniere. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We've thus far resisted a generic "http server" runnable, mainly because we didn't want to be responsible for generic HTTP serving in CR. |
Hi @DirectXMan12,
I can update the PR to have the What do you think? |
It should totally be possible to use "internal" handlers (like Unifying all internal handlers into a single HTTP server seems like it could be reasonable. We'd have to figure out if we want to allow people to put different things on different ports though (probably). |
Is this something that should be handled at by CR rather than the end controller level level (re: different ports @DirectXMan12?) it seems like CR may be able to offer an http.Server interface that can be used by end controllers, but I'm not so certain about having CR actually be the thing that calls ListenAndServe in this case. |
So, I think I'd like to see this, off the top of my head:
|
(so I think I'm agreeing with you, at least partially, @gerred) |
I would really like to see 3. Somehow I already achieve it by |
Thanks all for your comments. |
@clamoriniere are you still working on this or may I take over? |
Hi @alenkacz , |
@DirectXMan12 I am working on this functionality and I was following the discussion here. We currently expose |
@alenkacz yeah, I think we should deprecate that in favor of the piece of functionality described by bullet 3 above. I had completely forgotten that existed, thanks for the reminder :-P |
Co-authored-by: Camila Macedo <cmacedo@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clamoriniere The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
closing as per #743 (comment) |
I know this issue got closed but I am wondering why pprof is not considered as a by |
The idea is to have an
Http.Server
as amanager.Runnable
componentOn which other components can register
http.Handler
.The main benefice is to have only one http.Listener with multiples
http.Handler
:I saw a discussion on another PullRequest that seems to agree with this approach: #664 (comment)