🐛 wait for cache start before returning from WaitForCacheSync #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an unintuitive race condition between starting a cache, waiting for it to sync, and using it the first time. The crux of the problem is that WaitForCacheSync can return true BEFORE the Start function has had a chance to set started to true. This means that Get and List can return ErrCacheNotStarted even after WaitForCacheSync has returned true. This commit adds a channel and a wait function that is called from WaitForCacheSync to ensure that started has been set to true before returning.
k8s-ci-robot
added
cncf-cla: yes
|
/cc @DirectXMan12 |
|
nit: can you update the godoc on waitforcachesync to say "waits till started and synced" or somesuch? Otherwise lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an unintuitive race condition between starting
a cache, waiting for it to sync, and using it the first time.
The crux of the problem is that WaitForCacheSync can return true
BEFORE the Start function has had a chance to set started to true.
This means that Get and List can return ErrCacheNotStarted even
after WaitForCacheSync has returned true.
This commit adds a channel and a wait function that is called from
WaitForCacheSync to ensure that started has been set to true before
returning.