-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Add HasLabels helper option for List calls #792
✨Add HasLabels helper option for List calls #792
Conversation
/retest |
Signed-off-by: Vince Prignano <vincepri@vmware.com>
72b0730
to
ddfd3ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-controller-runtime-test-master |
/retest |
@vincepri I'd suggest you retitle the PR based on the name adjustment |
@gerred ptal |
/approve |
@vincepri though seems like there's still a test issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gerred, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems to be unrelated to these changes, seems like a flake? /retest |
yep. 👍 |
Signed-off-by: Vince Prignano vincepri@vmware.com
/assign @gerred @DirectXMan12