Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Create a supported way of setting a cache on source.Kind #794

Merged
merged 3 commits into from
Feb 17, 2020
Merged

✨ Create a supported way of setting a cache on source.Kind #794

merged 3 commits into from
Feb 17, 2020

Commits on Feb 10, 2020

  1. Create wrapper to explictly set cache 

    - sourceWithFixedCache does not implement InjectCache
- it does not rely on the current implicit implementation that a cache
is not overwriting in case it was injected before
- see #650

Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
    @achawki @c0d1ngm0nk3y @kramerul
    2 people authored and kramerul committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    cbaa31a View commit details
    Browse the repository at this point in the history

  2. Rename CreateSourceWithFixedCache to NewKindWithFixedCache 

    Co-authored-by: Ulrich Kramer <u.kramer@sap.com>
    @kramerul
    Jakob Schmid and kramerul committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    befff0b View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Change NewKindWithFixedCache to NewKindWithCache

    @kramerul
    kramerul committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    f515d1e View commit details
    Browse the repository at this point in the history