Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨enable webhook server set-up mTLS service to verify client's certificate #802

Merged
merged 2 commits into from
Mar 4, 2020
Merged

✨enable webhook server set-up mTLS service to verify client's certificate #802

merged 2 commits into from
Mar 4, 2020

Conversation

answer1991
Copy link
Contributor

Enable webhook server set-up mTLS service to verify client's certificate according to the given CAName

Not sure how to add UT, this package seems no UT for now?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @answer1991. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2020
@vincepri vincepri added this to the Next milestone Feb 21, 2020
@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2020
mengqiy
mengqiy reviewed Feb 21, 2020
View reviewed changes
pkg/webhook/server.go Outdated Show resolved Hide resolved
@mengqiy
Copy link
Member

mengqiy commented Feb 21, 2020

/retest

awgreene
awgreene suggested changes Feb 25, 2020
View reviewed changes
Copy link

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit - LGTM otherwise.

pkg/webhook/server.go Outdated
@@ -168,6 +174,23 @@ func (s *Server) Start(stop <-chan struct{}) error {
GetCertificate: certWatcher.GetCertificate,
}

// load CA to verify client certificate
if len(s.CAName) > 0 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you used len(s.CAName) over s.CAName != ""? Is there some optimization that I'm unaware of?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just personal coding habit.. Fixed, thanks!

mengqiy
mengqiy reviewed Feb 27, 2020
View reviewed changes
pkg/webhook/server.go Outdated Show resolved Hide resolved
@djzager
Copy link
Contributor

djzager commented Mar 3, 2020

Changes LGTM @answer1991 . I wonder if it would be reasonable to add this to the godoc in

controller-runtime/pkg/webhook/example_test.go

Line 52 in 39ee87b

hookServer := &Server{
to provide a meaningful example of starting the server with mTLS.

@mengqiy
Copy link
Member

mengqiy commented Mar 4, 2020

/lgtm
/approve
@answer1991 @djzager Feel free to add mTLS example in godoc example in a followup PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: answer1991, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 28f24de into kubernetes-sigs:master Mar 4, 2020
@answer1991
Copy link
Contributor Author

sure, I will finish it ASAP

@coderanger coderanger mentioned this pull request Jun 3, 2021
Closed
@sozercan sozercan mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy mengqiy left review comments

@awgreene awgreene awgreene requested changes

@alenkacz alenkacz Awaiting requested review from alenkacz

@gerred gerred Awaiting requested review from gerred

Assignees

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
6 participants
@answer1991 @k8s-ci-robot @vincepri @mengqiy @djzager @awgreene