-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨📖 Adding designs folder and sample template #809
✨📖 Adding designs folder and sample template #809
Conversation
/assign @vincepri |
f0777ed
to
02f329e
Compare
02f329e
to
a70c1c1
Compare
/assign @DirectXMan12 |
Let's not do the full KEP template. I'd like to see something closer to the KB template (in fact, I kinda just think we should copy it). IMO, at least for us, KEPs are too complicated, intimidating, and paperwork-heavy. |
Might be worth having a "is this a breaking change" section for controller-runtime too. What I'm looking for when I read a proposal is:
That's pretty much it in terms of structure. At least in my opinion, anything more than that just gets in the way of people actually doing things at this scale. Key point from the KB design template:
We should copy the designs README from KB too (adjusting slightly as necessary). |
a70c1c1
to
17f20b4
Compare
Signed-off-by: Chris Hein <me@chrishein.com>
17f20b4
to
59d237f
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein, DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per the discussion in the controller-runtime this fixes #807 adding so that I can add the design document for #518
Signed-off-by: Chris Hein me@chrishein.com