-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use GenerateName during fake client's Create method #815
🐛 Use GenerateName during fake client's Create method #815
Conversation
Closely matches the NameGenerator from APIServer
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @tvs! |
Hi @tvs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
CLA should be signed now. |
/assign @droot |
/assign @alvaroaleman @DirectXMan12 @gerred /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tvs, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It("should be able to Create with GenerateName", func() { | ||
By("Creating a new configmap") | ||
newcm := &corev1.ConfigMap{ | ||
TypeMeta: metav1.TypeMeta{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Setting the type meta is not needed
/lgtm |
When an object is created without a
Name
but with aGenerateName
, the fake client will set aName
by appending a randomly generated UID to the end of theGenerateName
prefix.This change replicates the behavior of the API Server's NameGenerator.