🐛 Fix testdata imports in pkg/webhook/conversion #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
alvaroaleman
approved these changes
Mar 6, 2020
djzager
approved these changes
Mar 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Addressed feedback - can someone add a lgtm? 😄 |
Anything in a |
k8s-ci-robot
added
the
lgtm
munnerz
added a commit
to munnerz/cert-manager
that referenced
this pull request
Mar 9, 2020
…time#843 Signed-off-by: James Munnelly <james@munnelly.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import path used here is incorrect, and there is no
go.modincluded in the root of this testdata directory to indicate its module name istestdata.kb.io(and I'm not actually certain this is a valid module path as it does not contain a/.Additionally, the
api/v1package itself importsv2assigs.k8s.io/controller-runtime/pkg/webhook/conversion/testdata/api/v2: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/webhook/conversion/testdata/api/v1/externaljob_types.go#L23I noticed this because Bazel attempts to resolve this import path in my project, and fails to resolve it to a real repository, leading to confusing log output when analysing our dependencies 😅