Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 KubeAwareEncoder should handle unstructured object correctly #881

Merged
merged 1 commit into from
Apr 14, 2020
Merged

🐛 KubeAwareEncoder should handle unstructured object correctly #881

merged 1 commit into from
Apr 14, 2020

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Apr 1, 2020

Surprisingly *unstructured.Unstructured does NOT implement the fmt.Striger interface.
We have to work around it in KubeAwareEncoder until it is fixed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2020
@mengqiy
Copy link
Member Author

mengqiy commented Apr 1, 2020

/assign @DirectXMan12

@vincepri vincepri added this to the v0.5.x milestone Apr 1, 2020
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DirectXMan12,mengqiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bac7e8a into kubernetes-sigs:master Apr 14, 2020
@mengqiy mengqiy deleted the loggerunstructured branch May 14, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz Awaiting requested review from alenkacz

@gerred gerred Awaiting requested review from gerred

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging this pull request may close these issues.
4 participants
@mengqiy @DirectXMan12 @k8s-ci-robot @vincepri