-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs using utilruntime.Must for scheme registration #894
Adding docs using utilruntime.Must for scheme registration #894
Conversation
Signed-off-by: Chris Hein <me@chrishein.com>
/assign @vincepri |
/unassign @vincepri |
@DirectXMan12 What is best practice using EDIT: nvm. kubernetes-sigs/kubebuilder#1462 (comment) seems to answer this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @mengqiy! |
In addition to adding scaffolded
utilruntime.Must
for scheme registration inkubebuilder
(kubernetes-sigs/kubebuilder#1462) this updates the docs forcontroller-runtime
docs to include panicking when scheme registration fails.You will notice that internal to
localSchemeBuilder
inclient-go
(https://github.com/kubernetes/client-go/blob/master/kubernetes/scheme/register.go#L133) and most schemes within kubernetes they cause panics if anything from conversions to defaults fail.After discussing with @DirectXMan12 this being left out probably either an oversight to that this pattern was developed after these packages where made.
Signed-off-by: Chris Hein me@chrishein.com