Get controller.go test coverage to 100% #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
droot
reviewed
Jun 8, 2018
pkg/controller/controller.go
Outdated
| @@ -93,6 +93,8 @@ type controller struct { | |||
| // the queue for processing | |||
| queue workqueue.RateLimitingInterface | |||
|
|
|||
| jitterPeriod time.Duration | |||
There was a problem hiding this comment.
May be a comment explaining what is this really for ?
pkg/controller/controller.go
Outdated
| @@ -145,21 +149,33 @@ func (c *controller) Start(stop <-chan struct{}) error { | |||
| for _, informer := range allInformers { | |||
| syncedFuncs = append(syncedFuncs, informer.HasSynced) | |||
| } | |||
| if ok := cache.WaitForCacheSync(stop, syncedFuncs...); !ok { | |||
|
|
|||
| // Allow waitForCache to be mocked out for tests | |||
There was a problem hiding this comment.
May be move this comment where this is declared ?
pkg/controller/controller.go
Outdated
| go wait.Until(func() { | ||
| // TODO(pwittrock): Should we really use wait.Until to continuously restart this if it exits? | ||
| fmt.Printf("Running\n") |
There was a problem hiding this comment.
These were debug statements :P
pkg/controller/controller.go
Outdated
| for c.processNextWorkItem() { | ||
| } | ||
| }, time.Second, stop) | ||
| fmt.Printf("Stopping\n") |
|
|
||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
nit: filename has "manger" --> manager :)
There was a problem hiding this comment.
Should Describe be "controller manager", and //TODO comments be needed ?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
fanzhangio
reviewed
Jun 8, 2018
|
|
||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Should Describe be "controller manager", and //TODO comments be needed ?
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
added
size/XL
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Get controller.go test coverage to 100%
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
Better help messaging for kubebuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.