Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom JSON marshaling causes schema validation generation to be skipped #466

Closed
christarazi opened this issue Jul 28, 2020 · 2 comments
Closed

Comments

@christarazi
Copy link

christarazi commented Jul 28, 2020

I have a CRD type as follows:

type A struct {
  metav1.TypeMeta
  metav1.TypeMeta

  Spec   Spec
  Status Status
}

The Spec field implements custom JSON marshaling. This causes the validation schema generation for Spec to be skipped, and replaced with type: Any. This is due to #427.

I expect to control this with a marker, or a similar knob. In this case, an opt-out marker makes sense if #427 implements sane default behavior.

@alvaroaleman
Copy link
Member

We've reverted #427 in #505 as type: Any is not valid.
/close

Feel free to re-open if you think the revert doesn't address the issue.

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman: Closing this issue.

In response to this:

We've reverted #427 in #505 as type: Any is not valid.
/close

Feel free to re-open if you think the revert doesn't address the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants