Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support min/max properties #487

Closed
moolen opened this issue Sep 5, 2020 · 0 comments · Fixed by #488
Closed

support min/max properties #487

moolen opened this issue Sep 5, 2020 · 0 comments · Fixed by #488
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@moolen
Copy link
Contributor

moolen commented Sep 5, 2020

The apiserver supports validation of minProperties/maxProperties, having support for that here would be great. oneOf is not supported (yet #461), this is a neat workaround to enable mutually exclusive parameters (see post on SO).
moolen added a commit to moolen/controller-tools that referenced this issue Sep 5, 2020
@moolen
feat: add min/max properties validation
4781e50 
fixes kubernetes-sigs#487

Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
@moolen moolen mentioned this issue Sep 5, 2020
Merged
@DirectXMan12 DirectXMan12 added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ add min/max properties validation moolen/controller-tools
2 participants
@DirectXMan12 @moolen