Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update dependencies to Kubernetes 1.12.2 #104

Closed
wants to merge 3 commits into from
Closed

[WIP] Update dependencies to Kubernetes 1.12.2 #104

wants to merge 3 commits into from

Conversation

jimmidyson
Copy link
Member

WIP until kubernetes-sigs/controller-runtime#221 is merged and a release tagged. Currently using the source branch from that PR as source for controller-runtime dependency to check it all works together.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimmidyson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: droot

If they are not already assigned, you can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2018
@jimmidyson
Copy link
Member Author

/assign @droot

@droot droot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2018
@droot droot assigned mengqiy and unassigned droot Dec 5, 2018
@droot
Copy link
Contributor

droot commented Dec 10, 2018

closing this since repo has been updated to k8s 1.12 release

@droot droot closed this Dec 10, 2018
@mengqiy
Copy link
Member

mengqiy commented Dec 10, 2018

This PR is superseded by #113 and we have decided to keep all direct dependencies in Gopkg.toml. E.g. k8s.io/apimachinery, k8s.io/api and others.
Both CR and CT has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@mengqiy mengqiy

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmidyson @k8s-ci-robot @droot @mengqiy