Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add test and warning for v1beta1 default removal #499

Merged
merged 2 commits into from
Nov 9, 2020
Merged

✨ Add test and warning for v1beta1 default removal #499

merged 2 commits into from
Nov 9, 2020

Conversation

kevindelgado
Copy link
Contributor

@kevindelgado kevindelgado commented Oct 2, 2020 •
edited
Loading

This is a follow up to #481 to include test cases and a warning for when v1beta1 CRDs are stripped of defaults.

Also fixes a gosec lint issue caused by "Implicit memory aliasing in for loop"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @kevindelgado!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2020
@kevindelgado
Copy link
Contributor Author

/assign @DirectXMan12
/cc @munnerz

@kevindelgado kevindelgado force-pushed the pr/follow-up-481 branch 2 times, most recently from 7e54c2e to 360e435 Compare October 2, 2020 01:47
@kevindelgado
Copy link
Contributor Author

friendly ping @DirectXMan12

DirectXMan12
DirectXMan12 suggested changes Oct 13, 2020
View reviewed changes
pkg/crd/gen.go Outdated Show resolved Hide resolved
pkg/crd/gen.go Outdated Show resolved Hide resolved
@kevindelgado
Copy link
Contributor Author

feedback addressed, PTAL @DirectXMan12

@kevindelgado
Copy link
Contributor Author

Can you take a look agaian @DirectXMan12

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, kevindelgado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit ede1d01 into kubernetes-sigs:master Nov 9, 2020
@kevindelgado kevindelgado mentioned this pull request Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@pwittrock pwittrock Awaiting requested review from pwittrock

@munnerz munnerz Awaiting requested review from munnerz

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevindelgado @k8s-ci-robot @DirectXMan12